Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch code of conduct to LF Projects #3

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

marbre
Copy link
Member

@marbre marbre commented Jan 5, 2025

Removes CONTRIBUTING.md in favor of CODE_OF_CONDUCT.md which points
to the LF Projects code of conduct.

@marbre marbre requested a review from ScottTodd January 5, 2025 16:11
@marbre
Copy link
Member Author

marbre commented Jan 5, 2025

I think pointing to the code of conducts for LF Projects makes sense here but for contributing, we might want to point to

To get started with contributing, please take a look at the
Contributing to LLVM guide. It
describes how to get involved, raise issues and submit patches.

instead of the IREE contributing guide? Referring to the IREE communication channels however seems resoable.

CONTRIBUTING.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pointing to the code of conducts for LF Projects makes sense here but for contributing, we might want to point to

To get started with contributing, please take a look at the
Contributing to LLVM guide. It
describes how to get involved, raise issues and submit patches.

instead of the IREE contributing guide? Referring to the IREE communication channels however seems resoable.

How about we just delete this file, or heavily simplify it? This is a fork with no regular development activities happening in it.

Could link to https://github.com/iree-org/megabump and any docs specific to managing the LLVM submodule.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting the file and just adding a CODE_OF_CONDUCT.md would work as well. How to get in touch is in the README anyway (even though this needs an update as well).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR description as well as the PR accordingly.

Removes `CONTRIBUTING.md` in favor of `CODE_OF_CONDUCT.md` which points
to the LF Projects code of conduct.
@marbre marbre force-pushed the users/marbre/contributing branch from a109090 to 1bfb5e6 Compare January 6, 2025 21:35
@marbre marbre requested a review from ScottTodd January 6, 2025 21:36
@marbre marbre merged commit edd72f9 into default Jan 6, 2025
1 check passed
@marbre marbre deleted the users/marbre/contributing branch January 6, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants